add box-select to ssr/graph (depends on #305)#312
Closed
AjayThorve wants to merge 56 commits into
Closed
Conversation
…into mzegar-viz-app-setup
trxcllnt
reviewed
Oct 14, 2021
trxcllnt
reviewed
Oct 14, 2021
Comment on lines
+128
to
+152
| componentDidMount() { | ||
| this.dispatchRemoteEvent(this.videoRef.current, 'blur'); | ||
| this.dispatchRemoteEvent(this.videoRef.current, 'wheel'); | ||
| this.dispatchRemoteEvent(window, 'beforeunload'); | ||
| this.dispatchRemoteEvent(document, 'keydown'); | ||
| this.dispatchRemoteEvent(document, 'keypress'); | ||
| this.dispatchRemoteEvent(this.videoRef.current, 'mouseup'); | ||
| this.dispatchRemoteEvent(this.videoRef.current, 'mousemove'); | ||
| this.dispatchRemoteEvent(this.videoRef.current, 'mousedown'); | ||
| this.dispatchRemoteEvent(this.videoRef.current, 'mouseenter'); | ||
| this.dispatchRemoteEvent(this.videoRef.current, 'mouseleave'); | ||
| } | ||
|
|
||
| dispatchRemoteEvent(target, type) { | ||
| let timeout = null; | ||
| target.addEventListener(type, (e) => { | ||
| if (e.target === this.videoRef.current) { | ||
| e.preventDefault(); | ||
| } | ||
| if (!timeout) { | ||
| timeout = setTimeout(() => { timeout = null; }, 1000 / 60); | ||
| this.peer.send(JSON.stringify({ type: 'event', data: serializeEvent(e) })); | ||
| } | ||
| }); | ||
| } |
Collaborator
There was a problem hiding this comment.
We shouldn't add event listeners to DOM elements directly, because React may destroy the underlying DOM element whenever it wants. Instead, use the onMouseUp={} etc. properties of the video element.
…into mzegar-viz-app-setup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds box-select and other interactions (clear selections, return filtered dataframes) for
ssr/graphdemo and is developed simultaneously with #305 for adding the same functionality to the viz demo app